Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/resilio: listen on [::1] by default #91128

Merged
merged 1 commit into from Jun 20, 2020
Merged

Conversation

@bbigras
Copy link
Contributor

bbigras commented Jun 19, 2020

Motivation for this change

fix #54482

Things done

I tested that it's listening on [::1] with the ss command.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maybe @Mic92

@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 20, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 20, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/status needs_review

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Jun 20, 2020
Copy link
Contributor

rnhmjoj left a comment

Looks good, however this is a breaking change: I would mention this in the release notes.

@bbigras bbigras force-pushed the bbigras:rslsync-localhost branch from 2bc388a to dbb5bdf Jun 20, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

Done. It's the first time I edited one of those docbook xml files, so I'm not sure if I did it right.

Copy link
Contributor

rnhmjoj left a comment

Thank you, the manual looks good.

@rnhmjoj rnhmjoj merged commit 1eef920 into NixOS:master Jun 20, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dbb5bdf"; rev="dbb5bdfa09eb4ecfce1b06a2a7e647ca13fa16c2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bbigras bbigras deleted the bbigras:rslsync-localhost branch Jun 20, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

Thanks!

@marvin-mk2 marvin-mk2 bot requested a review from timokau Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.