Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs: 0.5.1 -> 0.6.0 #91135

Merged
merged 1 commit into from Jun 20, 2020
Merged

ipfs: 0.5.1 -> 0.6.0 #91135

merged 1 commit into from Jun 20, 2020

Conversation

@Luflosi
Copy link
Contributor

Luflosi commented Jun 20, 2020

Motivation for this change

https://github.com/ipfs/go-ipfs/releases/tag/v0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

rnhmjoj left a comment

ofBorg says builds and nixosTests.ipfs passes.

@rnhmjoj rnhmjoj merged commit 2fb254c into NixOS:master Jun 20, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="50afcee"; rev="50afcee871382e7f9f5261c83d9f8c20feb99ed6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ipfs, ipfs.passthru.tests on aarch64-linux Success
Details
ipfs, ipfs.passthru.tests on x86_64-linux Success
Details
@Luflosi Luflosi deleted the Luflosi:update/ipfs branch Jun 20, 2020
@Ericson2314
Copy link
Member

Ericson2314 commented Jul 15, 2020

The release notes mention some migration in the config? Let's make sure the IPFS NixOS module is not doing anything deprecated?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jul 18, 2020

I diffed the config generated by NixOS and the ipfs init one: the only change is they started adding QUIC listen addresses.
We could change the default value of services.ipfs.swamAddresses to include QUIC, but there are no incompatibility, I think.

@Ericson2314
Copy link
Member

Ericson2314 commented Jul 18, 2020

Thanks for checking! Let's do that, good to hear there's nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.