Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: 1.9.3 -> 2.0.1 #91138

Merged
merged 3 commits into from Jun 26, 2020
Merged

podman: 1.9.3 -> 2.0.1 #91138

merged 3 commits into from Jun 26, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented Jun 20, 2020

https://github.com/containers/libpod/releases/tag/v2.0.0
https://github.com/containers/libpod/releases/tag/v2.0.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor Author

zowoq commented Jun 20, 2020

Can't reproduce this outside the test, seems like an issue with the test environment and not podman, etc.

We might want to merge the containers.conf and automatic subuid/subgid PRs with this, the major version bump seems like a good time to have user config changes.

@ofborg ofborg bot added the 6.topic: nixos label Jun 21, 2020
@zowoq zowoq marked this pull request as ready for review Jun 23, 2020
@zowoq zowoq force-pushed the zowoq:podman branch from c33cce9 to 68f7b51 Jun 24, 2020
Copy link
Member

saschagrunert left a comment

LGTM

@ofborg ofborg bot requested a review from saschagrunert Jun 24, 2020
@zowoq zowoq force-pushed the zowoq:podman branch from 68f7b51 to e894466 Jun 25, 2020
@zowoq zowoq changed the title podman: 1.9.3 -> 2.0.0 podman: 1.9.3 -> 2.0.1 Jun 25, 2020
Copy link
Member

saschagrunert left a comment

Yep, thank you for the updated PR. LGTM

@marsam
marsam approved these changes Jun 26, 2020
@zowoq zowoq merged commit a8efeed into NixOS:master Jun 26, 2020
17 checks passed
17 checks passed
podman, podman.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e894466"; rev="e89446656d1edf9fac9e2e3552980e97e86155a5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
podman, podman.passthru.tests on aarch64-linux Success
Details
podman, podman.passthru.tests on x86_64-linux Success
Details
@zowoq zowoq deleted the zowoq:podman branch Jun 26, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Jun 26, 2020

Upstream has darwin builds again so I'll take a look at fixing that in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.