Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grab-site: 2.1.16 -> 2.1.19 #91141

Merged
merged 2 commits into from Jun 22, 2020
Merged

grab-site: 2.1.16 -> 2.1.19 #91141

merged 2 commits into from Jun 22, 2020

Conversation

@ivan
Copy link
Member

ivan commented Jun 20, 2020

Motivation for this change

This fixes the build (namedlist tests fail on Python 3.8) and bumps grab-site to 2.1.19.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested grab-site, gs-server, and gs-dump-urls manually.

ivan added 2 commits Jun 20, 2020
ludios_wpull depends on namedlist, which is incompatible with Python 3.8
@ivan ivan changed the title grab-site: 2.1.6 -> 2.1.19 grab-site: 2.1.16 -> 2.1.19 Jun 20, 2020
@ivan
Copy link
Member Author

ivan commented Jun 20, 2020

For reference, the namedlist build failure on Python 3.8


running install tests
============================= test session starts ==============================
platform linux -- Python 3.8.3, pytest-5.4.3, py-1.8.1, pluggy-0.13.1
rootdir: /build/namedlist-1.7
collected 0 items / 1 error                                                    

==================================== ERRORS ====================================
___________________ ERROR collecting test/test_namedlist.py ____________________
test/test_namedlist.py:44: in <module>
    TestNL0 = namedlist('TestNL0', '')
/nix/store/83mqllma2scrkvhp68bd0mh42x7rdmp5-python3.8-namedlist-1.7/lib/python3.8/site-packages/namedlist.py:381: in namedlist
    type_dict = {'__init__': _make_fn('__init__', _nl_init, fields, defaults),
/nix/store/83mqllma2scrkvhp68bd0mh42x7rdmp5-python3.8-namedlist-1.7/lib/python3.8/site-packages/namedlist.py:180: in _make_fn
    code = compile(module_node, '<string>', 'exec')
E   TypeError: required field "posonlyargs" missing from arguments
=============================== warnings summary ===============================
/nix/store/83mqllma2scrkvhp68bd0mh42x7rdmp5-python3.8-namedlist-1.7/lib/python3.8/site-packages/namedlist.py:233
  /nix/store/83mqllma2scrkvhp68bd0mh42x7rdmp5-python3.8-namedlist-1.7/lib/python3.8/site-packages/namedlist.py:233: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    if isinstance(field_names, _collections.Mapping):

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========================== short test summary info ============================
ERROR test/test_namedlist.py - TypeError: required field "posonlyargs" missin...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
========================= 1 warning, 1 error in 0.30s ==========================
builder for '/nix/store/wiyfxqljpfcd6wphpb2sfjj7y1b400ch-python3.8-namedlist-1.7.drv' failed with exit code 2
Copy link
Member

timokau left a comment

Looks good, thanks.

@@ -12080,7 +12080,9 @@ in

gperftools = callPackage ../development/libraries/gperftools { };

grab-site = callPackage ../tools/backup/grab-site { };
grab-site = callPackage ../tools/backup/grab-site {
python3Packages = python37Packages;

This comment has been minimized.

Copy link
@timokau

timokau Jun 22, 2020

Member

I kind of prefer to pin such things locally in the nix expression, since it has a higher chance of getting noticed and removed there. I don't think we have any guidelines here though, so I won't block on that.

@timokau timokau merged commit f72a67f into NixOS:master Jun 22, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grab-site, grab-site.passthru.tests on aarch64-linux Success
Details
grab-site, grab-site.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7606a2a"; rev="7606a2ad7969a67dd4e5641dd0ee2a389fc8f907"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.