Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: add occ internal option #91149

Merged
merged 1 commit into from Jun 20, 2020
Merged

Conversation

@nlewo
Copy link
Member

nlewo commented Jun 20, 2020

Motivation for this change

This option exposes the prefconfigured nextcloud-occ
program. nextcloud-occ can then be used in other systemd services or
added in environment.systemPackages.

The nextcloud test shows how it can be add in
environment.systemPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This option exposes the prefconfigured nextcloud-occ
program. nextcloud-occ can then be used in other systemd services or
added in environment.systemPackages.

The nextcloud test shows how it can be add in
environment.systemPackages.
@nlewo nlewo requested a review from Ma27 Jun 20, 2020
@nlewo
Copy link
Member Author

nlewo commented Jun 20, 2020

@Ma27 I would like to backport it to 20.03 but I'm not sure our backporting policies would allow this... I'm however sure it would not break anything and wouldn't change derivation hashes since this is a "pending" option.
WDYT?

@Ma27
Copy link
Member

Ma27 commented Jun 20, 2020

I would like to backport it to 20.03 but I'm not sure our backporting policies would allow this... I'm however sure it would not break anything and wouldn't change derivation hashes since this is a "pending" option

Well, it's fairly useful addition (and probably even a "bugfix" since it wasn't possible to simply use nextcloud-occ for administrative tasks before) and I don't see how this would break something, so I'm fine with this.

Copy link
Member

Ma27 left a comment

I just realized that occ is already added to systemPackages in the module.

@Ma27
Copy link
Member

Ma27 commented Jun 20, 2020

hmm, OTOH it's still fine to make it available in e.g. a systemd service.

@Ma27
Ma27 approved these changes Jun 20, 2020
@Ma27 Ma27 merged commit c946263 into NixOS:master Jun 20, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d994ad"; rev="7d994ad445e4a0dac23c651ddcabbece51e76619"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ma27
Copy link
Member

Ma27 commented Jun 20, 2020

Thanks! Ported to stable as 6a99d5d.

@nlewo
Copy link
Member Author

nlewo commented Jun 22, 2020

Cool, thanks @Ma27 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.