Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spacy: fix build #91152

Merged
merged 4 commits into from Jun 21, 2020
Merged

python3Packages.spacy: fix build #91152

merged 4 commits into from Jun 21, 2020

Conversation

@danieldk
Copy link
Member

danieldk commented Jun 20, 2020

Motivation for this change

spaCy does not build anymore after the recent merge of staging. These changes fix the build.

Building spaCy with Python 2 does not work anymore due to the srsly bump. @FRidh maybe we should remove Python 2 support for spaCy altoghether? I saw that you kept around the old version of catalogue. But maintaining two versions of catalogue and srsly is probably not worth the effort.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh
Copy link
Member

FRidh commented Jun 20, 2020

But maintaining two versions of catalogue and srsly is probably not worth the effort.

If not used elsewhere, feel free to drop them

@danieldk
Copy link
Member Author

danieldk commented Jun 20, 2020

If not used elsewhere, feel free to drop them

Ack. I have added a commit dropping the old version of catalogue.

@danieldk danieldk force-pushed the danieldk:spacy-fixes branch from c2b604b to be79367 Jun 20, 2020
@danieldk danieldk requested a review from jonringer Jun 20, 2020
@danieldk
Copy link
Member Author

danieldk commented Jun 20, 2020

@jonringer thanks for the suggested changes! I have updated the PR.

@FRidh FRidh merged commit 71ace42 into NixOS:master Jun 21, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be79367"; rev="be79367b2566d88292e3cf754bb0aa0f20e060cb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.