Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.111.0 -> 0.111.4 #91154

Merged
merged 6 commits into from Jun 21, 2020
Merged

home-assistant: 0.111.0 -> 0.111.4 #91154

merged 6 commits into from Jun 21, 2020

Conversation

@Mic92
Copy link
Contributor

Mic92 commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mic92 added 3 commits May 31, 2020
This allows quick reloads using the following trick:

$(nix-build --show-trace --no-out-link \
  -E '(with import <nixpkgs/nixos> {};
       pkgs.writeScript "update-hass-config"
       config.systemd.services.home-assistant.preStart)')
systemctl reload home-assistant
@Mic92
Copy link
Contributor Author

Mic92 commented Jun 20, 2020

@GrahamcOfBorg test home-assistant

@Mic92 Mic92 force-pushed the Mic92:homeassistant branch 2 times, most recently from 033ae56 to 8af2ef4 Jun 20, 2020
@Mic92 Mic92 force-pushed the Mic92:homeassistant branch from 8af2ef4 to 5dbe66e Jun 20, 2020
@Mic92
Copy link
Contributor Author

Mic92 commented Jun 20, 2020

@GrahamcOfBorg test home-assistant

@Mic92
Copy link
Contributor Author

Mic92 commented Jun 20, 2020

I published an update script as well.

@Mic92
Copy link
Contributor Author

Mic92 commented Jun 20, 2020

Mhm. That eval issue looks unrelated to mine.

@jonringer
Copy link
Contributor

jonringer commented Jun 20, 2020

@FRidh
Copy link
Member

FRidh commented Jun 20, 2020

derivation 'homeassistant-0.111.4' has invalid meta attribute 'tests'
};

meta = with lib; {
homepage = "https://home-assistant.io/";
description = "Open-source home automation platform running on Python 3";
license = licenses.asl20;
maintainers = with maintainers; [ dotlambda globin mic92 ];
tests.nixos = nixosTests.fish;

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 20, 2020

Member

This should be in the passthru.

@dotlambda dotlambda linked an issue that may be closed by this pull request Jun 21, 2020
Mic92 added 2 commits Jun 20, 2020
@Mic92 Mic92 force-pushed the Mic92:homeassistant branch from 4ed7150 to a68c7e0 Jun 21, 2020
Copy link
Member

mweinelt left a comment

Deployed and tested. LGTM.

Unrelated nit: The met.no weather component is still not working 😢

@Mic92 Mic92 merged commit 9aa668e into NixOS:master Jun 21, 2020
16 of 17 checks passed
16 of 17 checks passed
home-assistant, home-assistant.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a68c7e0"; rev="a68c7e0fa7dca4107ffe83d21f3c53ba14c5c45f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
home-assistant, home-assistant.passthru.tests on aarch64-linux Success
Details
home-assistant, home-assistant.passthru.tests on x86_64-linux Success
Details
@Mic92 Mic92 deleted the Mic92:homeassistant branch Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.