Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efibootmgr,openldap: Cross compilation fixes #91156

Merged
merged 2 commits into from Jun 20, 2020

Conversation

@primeos
Copy link
Member

primeos commented Jun 20, 2020

Motivation for this change
[nix-review@ava:~/nixpkgs]$ nix-build -A efibootmgr -A pkgsCross.aarch64-multiplatform.efibootmgr -A openldap -A pkgsCross.aarch64-multiplatform.openldap
/nix/store/8m8cisgdjpzbrn2mrljbcaf9yvafgdkc-efibootmgr-17
/nix/store/52g903z38xwpyg03qnyi0p2xhqh2n9f7-efibootmgr-17-aarch64-unknown-linux-gnu
/nix/store/r54mh08dlmv86cb6c8p20904ljiyrvw9-openldap-2.4.50
/nix/store/kgs9smc6j0vs7734fn7yl04wps3bmwv5-openldap-2.4.50-aarch64-unknown-linux-gnu
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@primeos primeos requested review from FRidh and jonringer as code owners Jun 20, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 20, 2020
@ofborg ofborg bot requested a review from lovek323 Jun 20, 2020
@primeos primeos force-pushed the primeos:cross-compilation-fixes branch 2 times, most recently from 787e623 to 9ab7dd3 Jun 20, 2020
@primeos primeos force-pushed the primeos:cross-compilation-fixes branch from 9ab7dd3 to e408f3a Jun 20, 2020
@primeos primeos changed the base branch from master to staging Jun 20, 2020
primeos added 2 commits Jun 19, 2020
@primeos primeos force-pushed the primeos:cross-compilation-fixes branch from e408f3a to bf96533 Jun 20, 2020
@primeos primeos changed the title Various cross compilation fixes efibootmgr,openldap: Cross compilation fixes Jun 20, 2020
@primeos primeos merged commit ae3d755 into NixOS:staging Jun 20, 2020
17 of 18 checks passed
17 of 18 checks passed
efibootmgr, efibootmgr.passthru.tests, openldap, openldap.passthru.tests on x86_64-darwin
Details
efibootmgr, efibootmgr.passthru.tests, openldap.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
efibootmgr, efibootmgr.passthru.tests, openldap, openldap.passthru.tests on aarch64-linux Success
Details
efibootmgr, efibootmgr.passthru.tests, openldap, openldap.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf96533"; rev="bf965338df18335c1894855566badd0a4ecbccfa"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.