Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp4v2: 2.0.0 -> 4.1.3 #91159

Merged
merged 1 commit into from Jun 24, 2020
Merged

mp4v2: 2.0.0 -> 4.1.3 #91159

merged 1 commit into from Jun 24, 2020

Conversation

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Jun 20, 2020

Switch into the maintainable fork. It is the community central fork.

To compile, removed old patch URL, and using new upstream patch URL that corresponds with maintenance of 4.1.3.

I weighted-in upstream on the patch reasoning to be merged.

Strictify the hardening.

Documentation update.

Motivation for this change

Found that there is good, maintainable fork of the project.

Fork already used in Arch-based distros for quite some time: https://repology.org/project/libmp4v2/versions

Should close the "Vulnerability roundup 85: mp4v2-2.0.0: 6 advisories [9.8]" #90888, until this version goes through the new scan.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jun 20, 2020

@GrahamcOfBorg build mp4v2

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jun 20, 2020

Succesfully went through nix-shell -p nixpkgs-review --run "nixpkgs-review pr 91159" locally.

pkgs/development/libraries/mp4v2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mp4v2/default.nix Outdated Show resolved Hide resolved
Switch into maintanable fork. It is the community central fork.

Remove old patch, use new minor upstream patch to compile.

I weighted-in on the patch reasoning to be merged.

Strictify hardening.

Documentation update

M  pkgs/development/libraries/mp4v2/default.nix
@Anton-Latukha Anton-Latukha force-pushed the Anton-Latukha:upd-mp4v2-4.1.3 branch from 0256135 to c281c84 Jun 24, 2020
Copy link
Member

danieldk left a comment

Looks good!

Result of nixpkgs-review pr 91159 1

9 packages built:
- cinelerra
- darkice
- faac
- kid3
- mediatomb
- mixxx
- mp4v2
- split2flac
- zoneminder

Since is the upstream for various systems (Arch, NetBSD), it seems best to follow their lead.

@danieldk danieldk merged commit d8d19f2 into NixOS:master Jun 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c281c84"; rev="c281c84a1e19108f3ae4e06e6d99d254f7c9b5d8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mp4v2, mp4v2.passthru.tests on aarch64-linux Success
Details
mp4v2, mp4v2.passthru.tests on x86_64-linux Success
Details
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jun 24, 2020

It is the only, and so central maintained fork, in fact I kept an eye on it for some time, CVE report reminded me that switch is really beneficial. Thanks.

@Anton-Latukha Anton-Latukha deleted the Anton-Latukha:upd-mp4v2-4.1.3 branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.