Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] backport: nixos/btrfs autoScrub: don't fail when scrub finishes successfully #91162

Merged

Conversation

@symphorien
Copy link
Contributor

symphorien commented Jun 20, 2020

(cherry picked from commit 55d16d5)

I tested that a scrub can finish successfully and be cancelled successfully.

(cherry picked from commit 55d16d5)
@symphorien
Copy link
Contributor Author

symphorien commented Jul 4, 2020

cc @timokau who merged #84135

@timokau
Copy link
Member

timokau commented Jul 4, 2020

Have you only tried this once or have you been using it for a while? The testing standard for stable-branches is a bit higher than unstable, we should be reasonably sure that this will not break anybodies setup. Given that, do you think its good to go?

@symphorien
Copy link
Contributor Author

symphorien commented Jul 4, 2020

When I opened the PR, I switched my system to this branch, and successfully ran one scrub and cancelled one. Then I switched my system to stable again.

@timokau
Copy link
Member

timokau commented Jul 4, 2020

A one-time test might not catch unintended longterm consequences or breakage in edge-cases. In that case I'd rather let this sit in unstable for a bit. If nothing has happened until then, please ping me again in a week. Or if you're actively testing it yourself, 3 days are probably enough too.

@symphorien
Copy link
Contributor Author

symphorien commented Jul 21, 2020

@timokau timokau merged commit 9ea61f7 into NixOS:release-20.03 Jul 21, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="154c3f3"; rev="154c3f3013cc0d3ee18d810fb48d347e754e8210"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@timokau
Copy link
Member

timokau commented Jul 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.