Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radicale: 2.1.11 -> 3.0.3 #91168

Merged
merged 3 commits into from Jun 28, 2020
Merged

radicale: 2.1.11 -> 3.0.3 #91168

merged 3 commits into from Jun 28, 2020

Conversation

@dotlambda
Copy link
Member

dotlambda commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dotlambda
Copy link
Member Author

dotlambda commented Jun 20, 2020

@Valodim This breaks etesync-dav because it is too picky about the radicale version.


radicale = radicale2;
radicale = radicale3;

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jun 20, 2020

Author Member

Should this be moved to aliases.nix?

@dotlambda dotlambda requested review from rycee and andir Jun 21, 2020
@dotlambda dotlambda force-pushed the dotlambda:radicale-3.0.3 branch from 0b90f93 to d77fb37 Jun 23, 2020
@dotlambda
Copy link
Member Author

dotlambda commented Jun 25, 2020

@Valodim
Copy link
Contributor

Valodim commented Jun 25, 2020

thanks for the heads-up. I think etesync works with radicale3 at this point, too, I'll look into it.

\\ edit

ah, I see it was you who made that commit :) thanks!

@dotlambda dotlambda merged commit 595a3d1 into NixOS:master Jun 28, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d77fb37"; rev="d77fb3729dbad2a38e36d3b5726813866f43b545"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
radicale2, radicale2.passthru.tests, radicale3, radicale3.passthru.tests on aarch64-linux Success
Details
radicale2, radicale2.passthru.tests, radicale3, radicale3.passthru.tests on x86_64-darwin Success
Details
radicale2, radicale2.passthru.tests, radicale3, radicale3.passthru.tests on x86_64-linux Success
Details
@dotlambda dotlambda deleted the dotlambda:radicale-3.0.3 branch Jun 28, 2020
@Valodim Valodim mentioned this pull request Jul 20, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.