Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc-ble-driver: init at 4.1.1 #91173

Closed

Conversation

@siriobalmelli
Copy link
Contributor

siriobalmelli commented Jun 20, 2020

This is a requirement for the already-existing pc-ble-driver-py python module.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

This utility required to maintain a Nix CI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:add/pc-ble-driver branch 3 times, most recently from 7622570 to 3f21fd7 Jun 24, 2020
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:add/pc-ble-driver branch from 3f21fd7 to 106b4dd Jul 8, 2020
This is a requirement for the already-existing pc-ble-driver-py python module.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:add/pc-ble-driver branch from 106b4dd to 719c89d Jul 10, 2020
@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jul 19, 2020

This sat here for a month ... and was then independently done (and immediately committed) by @jonas-schievink here: e1a1b97

@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jul 19, 2020

... as committed will not build on Darwin. Reopening with patch: #93487

@siriobalmelli siriobalmelli changed the title pc-ble-driver: init at 4.1.1 pc-ble-driver: fix Darwin build Jul 19, 2020
@siriobalmelli siriobalmelli mentioned this pull request Jul 19, 2020
6 of 10 tasks complete
@siriobalmelli siriobalmelli changed the title pc-ble-driver: fix Darwin build pc-ble-driver: init at 4.1.1 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.