Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pylibgen: remove, upstream unmaintained #91183

Merged
merged 2 commits into from Jun 20, 2020

Conversation

@jonringer
Copy link
Contributor

jonringer commented Jun 20, 2020

Motivation for this change

package no longer builds, was going to fix then realized upstream has ended support for the package. https://github.com/joshuarli/pylibgen

also, @nico202 stated here that they are no longer active in nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Jun 20, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 20, 2020
@jonringer
Copy link
Contributor Author

jonringer commented Jun 20, 2020

I guess this is a dependency of papis as well.

cc @teto

EDIT: seems papis has removed it as a dependency: https://github.com/papis/papis/blob/master/setup.py

@jonringer jonringer force-pushed the jonringer:remove-pylibgen branch from f01c67b to 3fe28b8 Jun 20, 2020
@teto
teto approved these changes Jun 20, 2020
@jonringer
Copy link
Contributor Author

jonringer commented Jun 20, 2020

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/91183
2 packages built:
papis python37Packages.papis
@jonringer jonringer merged commit 011dd50 into NixOS:master Jun 20, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3fe28b8"; rev="3fe28b88a21c118bc0ec258c4b346bca5d12b594"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.