Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets: add flask with enableZero #91187

Open
wants to merge 1 commit into
base: master
from

Conversation

@lovesegfault
Copy link
Contributor

lovesegfault commented Jun 20, 2020

Motivation for this change

beets is currently broken, while attempting to debug it I encountered this missing dependency.

cc. @aszlig @domenkozar @pjones

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lovesegfault lovesegfault force-pushed the lovesegfault:beets-fix-zero-deps branch from 67bf317 to ddb81f7 Jun 20, 2020
@aszlig
aszlig approved these changes Jun 23, 2020
++ optional (enableWeb
|| enableZero) pythonPackages.flask
Comment on lines +160 to +161

This comment has been minimized.

Copy link
@aszlig

aszlig Jun 23, 2020

Member

Just a very pedantic nitpick (feel free to ignore as you please):

Suggested change
++ optional (enableWeb
|| enableZero) pythonPackages.flask
++ optional (enableWeb || enableZero) pythonPackages.flask

... plus changing all the other lines as well, so that in the end it looks like this (minus the first line of course):

{x=[ # <- just to avoid weird syntax highlighting :-)

  ] ++ optional enableAbsubmit            essentia-extractor
    ++ optional enableAcoustid            pythonPackages.pyacoustid
    ++ optional (enableFetchart
              || enableEmbyupdate
              || enableKodiupdate
              || enableLoadext
              || enablePlaylist
              || enableSubsonicupdate
              || enableAcousticbrainz)    pythonPackages.requests
    ++ optional enableCheck               plugins.check
    ++ optional enableConvert             ffmpeg_3
    ++ optional enableDiscogs             pythonPackages.discogs_client
    ++ optional enableGmusic              pythonPackages.gmusicapi
    ++ optional enableKeyfinder           keyfinder-cli
    ++ optional enableLastfm              pythonPackages.pylast
    ++ optional enableMpd                 pythonPackages.mpd2
    ++ optional enableSonosUpdate         pythonPackages.soco
    ++ optional enableThumbnails          pythonPackages.pyxdg
    ++ optional enableWeb                 pythonPackages.flask
    ++ optional (enableWeb || enableZero) pythonPackages.flask
    ++ optional enableAlternatives        plugins.alternatives
    ++ optional enableCopyArtifacts       plugins.copyartifacts;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.