Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: cleanups #91194

Merged
merged 9 commits into from Jun 21, 2020
Merged

thunderbird: cleanups #91194

merged 9 commits into from Jun 21, 2020

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Jun 20, 2020

Fixes issues #39976 and #39975 for Thunderbird and Firefox.

cc @taku0, @lovesegfault, @vcunat (#76118)

jtojnar added 6 commits Jun 20, 2020
It has not been used since 2015:

mozilla/gecko-dev@42c9261
It is only optionally dlopened by crash reporter to try to get system proxy settings
but no system stores proxy in GConf these days so it is completely useless.

https://github.com/mozilla/gecko-dev/blob/97c590ed5532a7b382b5b8500c109de8f1d831e3/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#L121-L122
jtojnar added 3 commits Jun 20, 2020
It is only optionally dlopened by crash reporter to try to get system proxy settings
but no system stores proxy in GConf these days so it is completely useless.

https://github.com/mozilla/gecko-dev/blob/97c590ed5532a7b382b5b8500c109de8f1d831e3/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#L121-L122
@taku0
taku0 approved these changes Jun 21, 2020
Copy link
Contributor

taku0 left a comment

LGTM.

Copy link
Contributor

lovesegfault left a comment

Nice

@jtojnar jtojnar merged commit 2b86087 into NixOS:master Jun 21, 2020
17 checks passed
17 checks passed
thunderbird, thunderbird-bin, thunderbird-bin.passthru.tests, thunderbird.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb700f7"; rev="eb700f7a9315c4a3e78eb58aae9f49b1e10040dd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
thunderbird, thunderbird-bin, thunderbird-bin.passthru.tests, thunderbird.passthru.tests on aarch64-linux Success
Details
thunderbird, thunderbird-bin, thunderbird-bin.passthru.tests, thunderbird.passthru.tests on x86_64-linux Success
Details
@jtojnar jtojnar deleted the jtojnar:thunderbird-cleanup branch Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.