Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastmod: init at 0.4.0 #91196

Merged
merged 2 commits into from Jun 22, 2020
Merged

fastmod: init at 0.4.0 #91196

merged 2 commits into from Jun 22, 2020

Conversation

@jduan
Copy link
Contributor

jduan commented Jun 20, 2020

Motivation for this change

This adds a package for https://github.com/facebookincubator/fastmod, a CLI tool for refactoring code.

Things done

I ran nix-build -A fastmod default.nix and tested the binary built. It worked as expected.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

danieldk left a comment

Thanks for submitting this package and contributing to nixpkgs 👍 !

I have suggested some changes, which should also fix the ofborg build.

pkgs/tools/text/fastmod/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/fastmod/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/fastmod/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/fastmod/default.nix Outdated Show resolved Hide resolved
description = "A utility that makes sweeping changes to large, shared code bases";
homepage = "https://github.com/facebookincubator/fastmod";
license = "Apache-2.0";
maintainers = with maintainers; [ swolchok ];

This comment has been minimized.

Copy link
@danieldk

danieldk Jun 21, 2020

Member

Add a separate commit (ordered before the commit that adds this derivation) to add yourself to maintainers/maintainer-list.nix. This should fix the ofborg error (since swolchok is currently undefined).

This comment has been minimized.

Copy link
@jduan

jduan Jun 21, 2020

Author Contributor

@danieldk thanks for your quick response and suggestions. I've applied them and added myself as a maintainer. All CI checks passed. PTAL.

This comment has been minimized.

Copy link
@danieldk

danieldk Jun 21, 2020

Member

Thanks for making these changes! Could you change the first line of the message of the commit where you add yourself to maintainers.nix to:

maintainers: add jduan

And then squash all the other commits (the ones for the derivation itself) into one commit with the following initial line in the commit message:

fastmod: init at 0.4.0

All commit messages in nixpkgs follow the same patterns to make it easy to find what was changed when ;).

In the commit history, the commit that adds you to maintainers.nix should be ordered before the one where the derivation is added.

If you need help fixing up the history, you can enable Allow edits and access to secrets by maintainers on in the rightmost column and let me know, and I can do the cleanup.

This comment has been minimized.

Copy link
@jduan

jduan Jun 21, 2020

Author Contributor

@danieldk thanks for suggesting the convention used by this repo! I've changed the commit history as you suggested. PTAL. Again, thanks for making my first contribution to this repo a pleasant experience!

@jduan jduan force-pushed the jduan:jduan--add-fastmod branch from 13642f5 to 33ccb8b Jun 21, 2020
Copy link
Member

danieldk left a comment

Sorry, one more glitch and then it should be good to go!

pkgs/tools/text/fastmod/default.nix Outdated Show resolved Hide resolved
@jduan jduan force-pushed the jduan:jduan--add-fastmod branch from d7b6717 to 5f48a53 Jun 21, 2020
Copy link
Member

danieldk left a comment

LGTM. Thanks a lot!

Result of nixpkgs-review pr 91196 1

1 package built:
- fastmod

Tested the resulting binary.

@danieldk danieldk merged commit 734f1de into NixOS:master Jun 22, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
fastmod, fastmod.passthru.tests on aarch64-linux Success
Details
fastmod, fastmod.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5f48a53"; rev="5f48a53f6912fa27255dc90f1461748ae11b0d72"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jduan
Copy link
Contributor Author

jduan commented Jun 22, 2020

@danieldk thanks for merging this PR and guiding me along the way. Really appreciate your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.