Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nixos-20.03 backport] Backport mutt 1.14.4 security issue patch #91197

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Jun 20, 2020

This was not yet tested by me and I am not able to verify that the issue is actually fixed by backporting this patch without modification to an old release of mutt.

Reviewers, please be careful

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
…ction attack

This patch backports the patch which was applied in mutt release 1.14.4.
From the release notes:

    This is an important bug-fix release. It fixes a possible
    machine-in-the-middle response injection attack when using STARTTLS
    with IMAP, POP3, and SMTP.

This patch applies the fix unmodified.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 20, 2020

I already patched mutt in 20.03 (PR #91072). I forgot to ping you, sorry.
I used the commit mentioned in the CVE text, yours is different, though: what's going on?

@matthiasbeyer
Copy link
Contributor Author

matthiasbeyer commented Jun 21, 2020

Huh, interesting! I used the patch Kevin (the mutt author) announced via the Mailinglist just yesterday. He wrote that there is no CVE number just yet! He wrote that yesterday but your commit is from two days ago... so I am confused now.

@Mic92
Copy link
Contributor

Mic92 commented Jun 22, 2020

Seems like there is nothing to do here.

@Mic92 Mic92 closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.