Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tornado: 5.1 -> 6.0.4 #91201

Closed
wants to merge 1 commit into from

Conversation

@marsam
Copy link
Contributor

marsam commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

for a more graceful upgrade, maybe we would introduce tornado_6 first, and slowly convert the packages over to that.

This would also cause 0 rebuilds

propagatedBuildInputs = [ backports_abc certifi singledispatch ]
++ lib.optional (pythonOlder "3.5") backports_ssl_match_hostname
++ lib.optional (pythonOlder "3.2") futures;
propagatedBuildInputs = lib.optionals isPy27 [ backports_abc certifi singledispatch backports_ssl_match_hostname futures ];

This comment has been minimized.

Copy link
@jonringer

jonringer Jun 21, 2020

Contributor

please format

Suggested change
propagatedBuildInputs = lib.optionals isPy27 [ backports_abc certifi singledispatch backports_ssl_match_hostname futures ];
propagatedBuildInputs = lib.optionals isPy27 [
backports_abc
certifi
singledispatch
backports_ssl_match_hostname
futures
];
}:

let
versionMap = {
"4.5.3" = {
sha256 = "02jzd23l4r6fswmwxaica9ldlyc2p6q8dk6dyff7j58fmdzf853d";
};
"5.1" = {

This comment has been minimized.

Copy link
@jonringer

jonringer Jun 21, 2020

Contributor

we may want to keep around a v5 for applications which aren't ready to upgrade to 6

@FRidh
Copy link
Member

FRidh commented Jun 21, 2020

This is going to need more testing.

@FRidh FRidh added this to WIP in Staging via automation Jun 21, 2020
@FRidh FRidh added this to the 20.09 milestone Jun 21, 2020
@marsam
Copy link
Contributor Author

marsam commented Jul 28, 2020

addressed in 234239b

@marsam marsam closed this Jul 28, 2020
Staging automation moved this from WIP to Done Jul 28, 2020
@marsam marsam deleted the marsam:update-python-tornado branch Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.