Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminus-font: make build reproducible by using `gzip -n` #91224

Merged
merged 1 commit into from Jun 23, 2020

Conversation

@iblech
Copy link
Contributor

iblech commented Jun 21, 2020

Motivation for this change

In current master, the terminus font is not reproducible. This is because the Makefile invokes gzip without -n, hence including timestamps.

This pull request adds the missing -n by patching the Makefile.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@iblech
Copy link
Contributor Author

iblech commented Jun 21, 2020

(I believe that the tests only failed because of a lack of disk space on the host.)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 23, 2020

@GrahamcOfBorg build terminus_font

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 23, 2020

Copy link
Contributor

rnhmjoj left a comment

Looks good. Thank you for spotting this!

@rnhmjoj rnhmjoj merged commit 4b8e31f into NixOS:master Jun 23, 2020
16 of 17 checks passed
16 of 17 checks passed
terminus_font on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a64a315"; rev="a64a315151ca0231970bf503ca8d62480bfdac23"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
terminus_font on aarch64-linux Success
Details
terminus_font on x86_64-linux Success
Details
@iblech
Copy link
Contributor Author

iblech commented Jun 24, 2020

Awesome, thank you for the quick review and merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.