Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3ipc-autotiling: init at d521cd6 #91244

Closed
wants to merge 2 commits into from
Closed

i3ipc-autotiling: init at d521cd6 #91244

wants to merge 2 commits into from

Conversation

@vldn-dev
Copy link

vldn-dev commented Jun 21, 2020

Useful autotiling script for i3 & sway.

Motivation for this change

Used it on my other machine, a simple script for automatic switch the tile mode from vertical to horizontal when the window is higher than bigger..

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Useful autotiling script for i3 & sway.
python3Packages.buildPythonApplication rec {
pname = "i3ipc-autotiling";
version = "d521cd6d26d0b3aadbd283fe4165235b5df386f2";
src = fetchTarball {

This comment has been minimized.

Copy link
@symphorien

symphorien Jun 21, 2020

Contributor

please use fetchFromGitHub instead.

Co-authored-by: symphorien <symphorien@users.noreply.github.com>

python3Packages.buildPythonApplication rec {
pname = "i3ipc-autotiling";
version = "d521cd6d26d0b3aadbd283fe4165235b5df386f2";

This comment has been minimized.

Copy link
@symphorien

symphorien Jun 21, 2020

Contributor

the nixpkgs manual says you should use the date as version if upstream does not tag versions.
See https://nixos.org/nixpkgs/manual/#sec-package-naming

mkdir -p "$out/bin"
cp autotiling.py "$out/bin/autotiling"'';
postInstall = ''
makeWrapper ${python3Packages.python.interpreter} $out/bin/${pname}-python-interpreter

This comment has been minimized.

Copy link
@symphorien

symphorien Jun 21, 2020

Contributor

i3ipc-autotiling-python-interpreter is a strange naming for the executable. Also are you sure the wrapping does not happen automatically by the magic of buildPythonPackage ?

This comment has been minimized.

Copy link
@vldn-dev

vldn-dev Jun 21, 2020

Author

should i fix it with commits here or should i pull it again?

This comment has been minimized.

Copy link
@symphorien

symphorien Jun 21, 2020

Contributor

You can do the modifications locally wit git commit --amend or git rebase -i and then git push --force-with-lease. This will update the content of the pull request.

@Artturin Artturin mentioned this pull request Jul 30, 2020
4 of 10 tasks complete
@ryantm ryantm closed this in #94203 Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.