Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seeks: remove, upstream unmaintained #91256

Merged
merged 1 commit into from Sep 18, 2020
Merged

seeks: remove, upstream unmaintained #91256

merged 1 commit into from Sep 18, 2020

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Jun 21, 2020

Motivation for this change
  • Remove seeks package.
  • Upstream is dead since 2014.
  • Package is broken since 2018.
  • Project homepage domain is for sale.

He's dead, Jim.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@worldofpeace worldofpeace left a comment

This change is pretty important that it is made.
Otherwise, it sounds like a good removal.

nixos/modules/module-list.nix Show resolved Hide resolved
@prusnak prusnak force-pushed the prusnak:seeks branch from afa3b73 to 46d2a3b Jun 22, 2020
nixos/modules/rename.nix Outdated Show resolved Hide resolved
@prusnak prusnak force-pushed the prusnak:seeks branch from 46d2a3b to 2e0542e Jun 22, 2020
@mmahut mmahut merged commit 52532b7 into NixOS:master Sep 18, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0542e"; rev="2e0542ebacb2b8cb938d848ab743ca9df702f56e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:seeks branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.