Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: add section on Intel DDX drivers #91261

Merged
merged 1 commit into from Jun 23, 2020
Merged

nixos/doc: add section on Intel DDX drivers #91261

merged 1 commit into from Jun 23, 2020

Conversation

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 21, 2020

Motivation for this change

Document findings from #19231

Things done
  • Tested using sandboxing (nix.useSandbox
  • Built manual
  • Check informations are correct
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 21, 2020

Rendered:
image

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:intel branch from 49e1c5d to 0e3418a Jun 22, 2020
Copy link
Contributor

flokli left a comment

Went for another round, found some more typos.

I also think it makes sense to reorder the paragraphs, to make it more clear what's the recommended approach and what the workaround for older hardware.

nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:intel branch from 0e3418a to 1b17b3b Jun 22, 2020
@flokli
Copy link
Contributor

flokli commented Jun 22, 2020

LGTM!

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 23, 2020

Thank you for reviewing!

@rnhmjoj rnhmjoj merged commit 1b5e0d4 into NixOS:master Jun 23, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1b17b3b"; rev="1b17b3b915fce00a1273a9b7247a4ebfb89a4d1d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.