Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topgrade: 4.7.0 -> 4.8.0 #91274

Merged
merged 1 commit into from Jun 23, 2020
Merged

topgrade: 4.7.0 -> 4.8.0 #91274

merged 1 commit into from Jun 23, 2020

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Jun 22, 2020

Motivation for this change

https://github.com/r-darwish/topgrade/releases/tag/v4.8.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk
Copy link
Member

danieldk commented Jun 22, 2020

There is this comment in the derivation ;):

# TODO: add manpage (topgrade.8) to postInstall on next update
Copy link
Member

danieldk left a comment

LGTM

Result of nixpkgs-review pr 91274 1

1 package built:
- topgrade

ofborg is still stuck on Darwin and you may want to add a change to install the man page as suggested ;).

Copy link
Contributor

HugoReeves left a comment

Built and executed successfully on NixOS.
LGTM

@danieldk danieldk merged commit fdfe99b into NixOS:master Jun 23, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c0a6e8"; rev="4c0a6e855c674183b59e1725698c97961e4c792e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
topgrade, topgrade.passthru.tests on aarch64-linux Success
Details
topgrade, topgrade.passthru.tests on x86_64-darwin Success
Details
topgrade, topgrade.passthru.tests on x86_64-linux Success
Details
@filalex77
Copy link
Contributor Author

filalex77 commented Jun 23, 2020

@danieldk Thanks for pointing out, I forgot about it! Will address in the next update :)

@filalex77 filalex77 deleted the filalex77:topgrade-4.8.0 branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.