Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protonvpn-cli-ng: 2.2.2 -> 2.2.4 #91328

Merged
merged 1 commit into from Jul 2, 2020
Merged

protonvpn-cli-ng: 2.2.2 -> 2.2.4 #91328

merged 1 commit into from Jul 2, 2020

Conversation

@privateseabass
Copy link
Contributor

privateseabass commented Jun 23, 2020

ProtonVPN-cli-ng: 2.2.2 -> 2.2.4

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@privateseabass privateseabass changed the title WIP: ProtonVPN-cli-ng: 2.2.2 => 2.2.4 WIP: protonvpn-cli-ng: 2.2.2 => 2.2.4 Jun 23, 2020
@ofborg ofborg bot requested a review from jtcoolen Jun 23, 2020
@privateseabass
Copy link
Contributor Author

privateseabass commented Jun 23, 2020

So... It still worked without erroring about the hash. I guess it did not change the binary, which is what I assume would change the hash?
Let me know if anything needs to be looked at.

@privateseabass privateseabass changed the title WIP: protonvpn-cli-ng: 2.2.2 => 2.2.4 protonvpn-cli-ng: 2.2.2 => 2.2.4 Jun 23, 2020
@jtcoolen
Copy link
Member

jtcoolen commented Jun 23, 2020

You're right. In order to get the new hash, you can change a character in the hash and rebuild the package. Then you'll find the expected hash in the stack trace once the rebuild failed.

@privateseabass
Copy link
Contributor Author

privateseabass commented Jun 26, 2020

I ran nixpkgs-review for it.
Ran fine, and didn't error.
Binary works.
Is it possible that the update didn't change the hash of the binary?

@jtcoolen
Copy link
Member

jtcoolen commented Jun 26, 2020

No, if you didn't change the hash then it didn't build the new executable. Check its version with -v.
So please change the hash as explained above (it should be 08yca0a0prrnrc7ir7ajd56yxvxpcs4m1k8f5kf273f5whgr7wzw).
Then add the python library jinja2 to the propagatedBuildInputs since it has been introduced in the meantime.

@privateseabass privateseabass changed the title protonvpn-cli-ng: 2.2.2 => 2.2.4 WIP: protonvpn-cli-ng: 2.2.2 => 2.2.4 Jun 27, 2020
@privateseabass
Copy link
Contributor Author

privateseabass commented Jun 27, 2020

Okay, I see what you mean.
Sorry, I didn't realize that was the case.

@privateseabass privateseabass force-pushed the privateseabass:patch-4 branch 2 times, most recently from 3161d9b to f8185a7 Jun 27, 2020
@privateseabass
Copy link
Contributor Author

privateseabass commented Jun 27, 2020

Okay, got it squashed.
Let me know if there is anything else I should do!

@privateseabass privateseabass changed the title WIP: protonvpn-cli-ng: 2.2.2 => 2.2.4 protonvpn-cli-ng: 2.2.2 => 2.2.4 Jun 27, 2020
@jtcoolen
Copy link
Member

jtcoolen commented Jun 29, 2020

Great! Could you rename the commit message to conform to the guidelines?

@privateseabass privateseabass changed the title protonvpn-cli-ng: 2.2.2 => 2.2.4 protonvpn-cli-ng: 2.2.2 -> 2.2.4 Jul 1, 2020
Changed version number and added Jinja2 to propagatedBuildInputs.
@privateseabass privateseabass force-pushed the privateseabass:patch-4 branch from f8185a7 to 53bee28 Jul 1, 2020
@privateseabass
Copy link
Contributor Author

privateseabass commented Jul 1, 2020

That look about right?

Copy link
Member

jtcoolen left a comment

Perfect, thank you!

@jtcoolen jtcoolen requested a review from bhipple Jul 1, 2020
@ofborg ofborg bot requested a review from jtcoolen Jul 1, 2020
@bhipple
Copy link
Contributor

bhipple commented Jul 2, 2020

Result of nixpkgs-review pr 91328 1

1 package built:
- protonvpn-cli-ng
@bhipple
bhipple approved these changes Jul 2, 2020
@bhipple bhipple merged commit 42ea899 into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="53bee28"; rev="53bee280a7ced5342eaa35e5a720b24bb96068a8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protonvpn-cli-ng, protonvpn-cli-ng.passthru.tests on aarch64-linux Success
Details
protonvpn-cli-ng, protonvpn-cli-ng.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.