Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k4dirstat: init at 3.2.1 #91345

Merged
merged 1 commit into from Jun 28, 2020
Merged

k4dirstat: init at 3.2.1 #91345

merged 1 commit into from Jun 28, 2020

Conversation

@raboof
Copy link
Contributor

raboof commented Jun 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

IvarWithoutBones left a comment

Some spacing + meta stuff seems odd, heres a suggestion:

{ stdenv
, mkDerivation
, fetchFromGitHub
, extra-cmake-modules
, kdoctools
, kiconthemes
, kio
, kjobwidgets
, kxmlgui
}:

mkDerivation rec {
  pname = "k4dirstat";
  version = "3.2.1";

  src = fetchFromGitHub {
    owner = "jeromerobert";
    repo = pname;
    rev = version;
    sha256 = "15xjb80jq6vhzvzx4l341f40d8a23w1334qh6cczqm9adfnzycp7";
  };

  nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ];
  buildInputs = [ kiconthemes kio kjobwidgets ];

  meta = with stdenv.lib; {
    homepage = "https://github.com/jeromerobert/k4dirstat";
    description = "A small utility program that sums up disk usage for directory trees";
    license = licenses.gpl2;
    maintainers = [ maintainers.raboof ];
    platforms = platforms.linux;
  };
}
};
nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ];
buildInputs = [ kiconthemes kio kjobwidgets ];
propagatedBuildInputs = [ ];

This comment has been minimized.

Copy link
@IvarWithoutBones

IvarWithoutBones Jun 24, 2020

Contributor

This defaults to being empty, no? You can just remove it.

description = "A small utility program that sums up disk usage for directory trees";
maintainers = [ lib.maintainers.raboof ];
};
nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ];

This comment has been minimized.

Copy link
@IvarWithoutBones

IvarWithoutBones Jun 24, 2020

Contributor

Shouldn't kdoctools and kxmlgui be regular buildInputs?

@raboof raboof force-pushed the raboof:k4dirstat-init-at-3.2.1 branch from 59b7df8 to b5b84be Jun 25, 2020
@raboof
Copy link
Contributor Author

raboof commented Jun 25, 2020

Updated, thanks!

Copy link
Contributor

IvarWithoutBones left a comment

LGTM :)

@nh2
Copy link
Contributor

nh2 commented Jun 28, 2020

Result of nixpkgs-review pr 91345 1

1 package built:
- k4dirstat
@nh2
Copy link
Contributor

nh2 commented Jun 28, 2020

GUI works for me.

@nh2 nh2 merged commit 430f3f1 into NixOS:master Jun 28, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b84be"; rev="b5b84be95bc0c30d821300b11edb337c884edea8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
k4dirstat, k4dirstat.passthru.tests on aarch64-linux Success
Details
k4dirstat, k4dirstat.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.