Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytree: init at 2.02 #91373

Merged
merged 1 commit into from Jun 25, 2020
Merged

ytree: init at 2.02 #91373

merged 1 commit into from Jun 25, 2020

Conversation

@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 23, 2020

ytree is a simple file manager, inspired in the venerable DOS xtree command.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@iblech
iblech approved these changes Jun 24, 2020
Copy link
Contributor

iblech left a comment

Very cool, thanks for packaging this! I confirm that your build works here. :-)

I had a quick look at the Debian patches for ytree. The ncurses header change looks potentially relevant, but I don't really know. In any case, I didn't notice any graphical glitches with file names containing umlauts or emojis. Cool that we package a newer version than Debian. :-)

We could make the build more reproducible by substituing gzip in the Makefile by gzip -n, as in this commit. This way the current time won't find its way into the gzipped files.

version = "2.02";

src = fetchurl {
url = "https:/han.de/~werner/${pname}-${version}.tar.gz";

This comment has been minimized.

Copy link
@iblech

iblech Jun 24, 2020

Contributor

Should be https://, not https:/ :-)

This comment has been minimized.

Copy link
@AndersonTorres

AndersonTorres Jun 24, 2020

Author Member

Oh man!

@iblech
Copy link
Contributor

iblech commented Jun 24, 2020

Actually please disregard the suggestions regarding reproducibility. The situation with the linked commit was different, there the files to be gzipped have been dynamically created by the make process. Here they are part of the source archive and hence already have a fixed timestamp.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jun 24, 2020

As far as I have seen on Nixpkgs, ncurses is already with wide support. I will use it explicitly.

And I will use the gzip option anyway. It will not hurt anyone, after all.

ytree is a simple file manager, inspired in the venerable DOS xtree command.
@AndersonTorres AndersonTorres force-pushed the AndersonTorres:create-ytree branch from f904644 to 0757cd4 Jun 24, 2020
@AndersonTorres AndersonTorres merged commit 435963c into NixOS:master Jun 25, 2020
16 checks passed
16 checks passed
ytree, ytree.passthru.tests on aarch64-linux Failure
Details
ytree, ytree.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0757cd4"; rev="0757cd4dbd174392156a0ac0e0753c0e356b8392"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@AndersonTorres AndersonTorres deleted the AndersonTorres:create-ytree branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.