Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hstr: install manpage #91381

Merged
merged 1 commit into from Jun 24, 2020
Merged

hstr: install manpage #91381

merged 1 commit into from Jun 24, 2020

Conversation

@teto
Copy link
Contributor

teto commented Jun 23, 2020

Motivation for this change

wanted to try the software to bookmark parts of my shell history and ended up simplifying it a bit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

danieldk left a comment

Result of nixpkgs-review pr 91381 1

1 package built:
- hstr

Tested the resulting binary.

Nice improvement, not only adds the man page, but also bash shell completions 👍 .

@danieldk danieldk merged commit 455fca0 into NixOS:master Jun 24, 2020
16 of 17 checks passed
16 of 17 checks passed
hstr, hstr.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dde159f"; rev="dde159fd98f8f0352571a443a8cc8451c03a4c40"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hstr, hstr.passthru.tests on aarch64-linux Success
Details
hstr, hstr.passthru.tests on x86_64-linux Success
Details
@teto teto deleted the teto:hstr branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.