Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpsbabel: enable usb #91439

Closed
wants to merge 1 commit into from
Closed

gpsbabel: enable usb #91439

wants to merge 1 commit into from

Conversation

@wamserma
Copy link
Contributor

wamserma commented Jun 24, 2020

Motivation for this change
$ gpsbabel  -t -i gtrnctr -f ~/.wine/userdata/tmp.tcx -o garmin -F usb:0
USB support is not available in this build.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 91439"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

wamserma commented Jun 24, 2020

Closure size:

#new
nix path-info -S /nix/store/kqi6psn7wdpfjcvkjk6lxsmbzk5k9z26-gpsbabel-1.6.0
/nix/store/kqi6psn7wdpfjcvkjk6lxsmbzk5k9z26-gpsbabel-1.6.0	 1026930768

#old
nix path-info -S /nix/store/c6ckp8lc741pgx70gcw3kd68m5iy9hql-gpsbabel-1.6.0
/nix/store/c6ckp8lc741pgx70gcw3kd68m5iy9hql-gpsbabel-1.6.0	 1026889000
@markuskowa
Copy link
Member

markuskowa commented Jun 27, 2020

@GrahamcOfBorg build gpsbabel

rycee added a commit that referenced this pull request Jul 2, 2020
PR #91439
@rycee
Copy link
Member

rycee commented Jul 2, 2020

Thanks! Rebased to master in caa858d.

@rycee rycee closed this Jul 2, 2020
@wamserma wamserma deleted the wamserma:gpsbabel-enable-usb branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.