Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.buildOasis: fix handling of installation prefix #91465

Merged
merged 1 commit into from Jul 2, 2020

Conversation

@vbgl
Copy link
Contributor

vbgl commented Jun 25, 2020

Motivation for this change

Currently, build of ocaml-ng.ocamlPackages_4_11.tcslib fails with a mysterious sed error:

sed: -e expression #1, char 70: unknown option to `s'

This PR gives correct arguments to the configure script, hence removes the need for patching its results.

cc @mgttlinger

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

mgttlinger left a comment

Looks good to me. I didn't know any better when I implemented this originally.

@vbgl
Copy link
Contributor Author

vbgl commented Jun 25, 2020

@GrahamcOfBorg build ocamlPackages.pgsolver ocaml-ng.ocamlPackages_4_11.tcslib

@vbgl vbgl merged commit 885fb14 into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84b39a5"; rev="84b39a57aeb3f62ebf137b64c3a59377e37d121b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocaml-ng.ocamlPackages_4_11.tcslib, ocamlPackages.pgsolver on aarch64-linux Success
Details
ocaml-ng.ocamlPackages_4_11.tcslib, ocamlPackages.pgsolver on x86_64-darwin Success
Details
ocaml-ng.ocamlPackages_4_11.tcslib, ocamlPackages.pgsolver on x86_64-linux Success
Details
@vbgl vbgl deleted the vbgl:ocaml-buildoasis-prefix branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.