Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greg: add setuptools to propagatedBuildInputs #91512

merged 1 commit into from Nov 29, 2020


Copy link

@kalekseev kalekseev commented Jun 25, 2020

Motivation for this change

#84353 (comment)
@petersjt014 I don't use greg just added missing dependency, could you test that it works as expected?

❯ nix-shell -p greg --run 'greg --version'
Traceback (most recent call last):
  File "/nix/store/s7nib0jpr3xnqv57a8322r1fnmhn5a92-greg-0.4.7/bin/.greg-wrapped", line 6, in <module>
    from greg.parser import main
  File "/nix/store/s7nib0jpr3xnqv57a8322r1fnmhn5a92-greg-0.4.7/lib/python3.8/site-packages/greg/", line 22, in <module>
    import greg.commands as commands
  File "/nix/store/s7nib0jpr3xnqv57a8322r1fnmhn5a92-greg-0.4.7/lib/python3.8/site-packages/greg/", line 24, in <module>
    import greg.classes as c
  File "/nix/store/s7nib0jpr3xnqv57a8322r1fnmhn5a92-greg-0.4.7/lib/python3.8/site-packages/greg/", line 32, in <module>
    from pkg_resources import resource_filename
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@ofborg ofborg bot requested a review from edwtjo Jun 25, 2020
@SuperSandro2000 SuperSandro2000 merged commit 96ee7ac into NixOS:master Nov 29, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants