Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] libtomcrypt: fix CVE-2019-17362 (security, backport) #91522

Merged

Conversation

@wamserma
Copy link
Contributor

wamserma commented Jun 25, 2020

(cherry picked from commit 5f16eca)

Motivation for this change

#90860

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit 5f16eca)
@wamserma
Copy link
Contributor Author

wamserma commented Jun 28, 2020

ping @nh2

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020

Result of nixpkgs-review pr 91522 1

1 package failed to build:
- bitkeeper
1 package built:
- libtomcrypt
@wamserma
Copy link
Contributor Author

wamserma commented Jun 29, 2020

bitkeeper is marked as broken

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020

bitkeeper is marked as broken

Yes also doesn't compile before the commit, so this PR does not regress it.

@nh2 nh2 merged commit 1cf3aff into NixOS:release-20.03 Jun 29, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05c4441"; rev="05c444144b0f3114e13c29aa7f2e25a00e75f5ab"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libtomcrypt, libtomcrypt.passthru.tests on aarch64-linux Success
Details
libtomcrypt, libtomcrypt.passthru.tests on x86_64-linux Success
Details
@wamserma wamserma deleted the wamserma:libtomcrypt-cve-2019-17362-backport branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.