Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.bidict: fix build #91528

Merged
merged 4 commits into from Jun 29, 2020
Merged

python3Packages.bidict: fix build #91528

merged 4 commits into from Jun 29, 2020

Conversation

@jonringer
Copy link
Contributor

jonringer commented Jun 26, 2020

Motivation for this change

noticed it was broken reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Jun 26, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 26, 2020
@ofborg ofborg bot requested a review from jbaum98 Jun 26, 2020
jonringer added 3 commits Jun 26, 2020
@jonringer
Copy link
Contributor Author

jonringer commented Jun 26, 2020

https://github.com/NixOS/nixpkgs/pull/91528
1 package failed to build:
google-music-scripts

12 packages built:
python37Packages.audio-metadata python37Packages.bidict python37Packages.google-music python37Packages.google-music-proto python37Packages.google-music-utils python37Packages.tbm-utils python38Packages.audio-metadata python38Packages.bidict python38Packages.google-music python38Packages.google-music-proto python38Packages.google-music-utils python38Packages.tbm-utils
@jonringer
Copy link
Contributor Author

jonringer commented Jun 26, 2020

tried relaxing version bound on google-music-scripts and updating it, but it's behind on tomlkit, loguru, and pendulum. So it doesn't even run if I do that. I'll let the maintainer @jbaum98 fix that package

@jonringer jonringer merged commit 7986ae5 into NixOS:master Jun 29, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b670d34"; rev="b670d3480d1e11df67abe749115359b7a59ef0e4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.