Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdevil: fix build with new ddcutil [blocks nixos-unstable] #91676

Merged
merged 1 commit into from Jun 29, 2020

Conversation

@cole-h
Copy link
Member

cole-h commented Jun 27, 2020

https://hydra.nixos.org/build/123207159

The KDE ISO depends on this package, which blocks nixos-unstable.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cole-h cole-h requested a review from ttuegel as a code owner Jun 27, 2020
@cole-h cole-h changed the title powerdevil: fix build with new ddcutil powerdevil: fix build with new ddcutil [blocks nixos-unstable] Jun 27, 2020
@cole-h
Copy link
Member Author

cole-h commented Jun 27, 2020

@ofborg test plasma5

https://hydra.nixos.org/build/123207159

The KDE ISO depends on this package, which blocks nixos-unstable.

Upstream bug: https://bugs.kde.org/show_bug.cgi?id=423605
@cole-h cole-h force-pushed the cole-h:powerdevil branch from ffe9c1a to dc113b9 Jun 29, 2020
@srhb srhb merged commit 041e1ab into NixOS:master Jun 29, 2020
17 checks passed
17 checks passed
powerdevil, powerdevil.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dc113b9"; rev="dc113b96a81a49a0e056990c51f1505a35fb75f7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
powerdevil, powerdevil.passthru.tests on aarch64-linux Success
Details
powerdevil, powerdevil.passthru.tests on x86_64-linux Success
Details
@cole-h cole-h deleted the cole-h:powerdevil branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.