Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse-mat: init at 1.10.0.20200225 #91700

Closed
wants to merge 1 commit into from
Closed

Conversation

@ktor
Copy link
Member

ktor commented Jun 28, 2020

Closes #43611

Motivation for this change

To add best, free, java memory analyzer to NixOS package collection.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ktor
Copy link
Member Author

ktor commented Jun 28, 2020

Hi @rycee, could you please review the pull request? I've based the package on build-eclipse.nix expression from eclipse package because it was easier for me. I am not able to judge it would work within the eclipse package better and don't know how would I integrate it there. Could you please comment on that?

@rycee
Copy link
Member

rycee commented Jun 28, 2020

This package does not seem to belong in the editors namespace so having it this way seems fine to me.

Closes #43611
@ktor ktor force-pushed the ktor:eclipse-mat-init branch from 058f9e1 to f1d45b6 Jun 28, 2020
@ktor
Copy link
Member Author

ktor commented Jun 28, 2020

Thank you @rycee for the review! I've resolved all your suggestions.

@ktor ktor requested a review from rycee Jun 29, 2020
@rycee
Copy link
Member

rycee commented Jul 2, 2020

Thanks! I ran nixpkgs-fmt to do some minor cleanups and rebased to master in 17e1fbe.

@rycee rycee closed this Jul 2, 2020
@ktor
Copy link
Member Author

ktor commented Jul 3, 2020

Thank you for the information @rycee , will use the formatter in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.