Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_testing_bcachefs: 5.3 -> 5.7 #91749

Open
wants to merge 4 commits into
base: master
from

Conversation

@cidkidnix
Copy link

cidkidnix commented Jun 29, 2020

Motivation for this change

Update bcachefs kernel to 5.7.0 so bcachefs users aren't stuck on 5.3

NOTE: I'm new to contributing to nixpkgs, so I'm sorry in advanced

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@srhb
Copy link
Contributor

srhb commented Jun 29, 2020

Hi and thank you! Looks all good to me. There's actually a small test suite you can run from your checkout like this, if you didn't know: nix-build ./nixos/tests/bcachefs.nix -- mine's still building.

cc @eadwu as the last person who touched this -- any reason not to bump from 5.3 -> 5.7?

@srhb
Copy link
Contributor

srhb commented Jun 29, 2020

The test does not succeed for me.

@cidkidnix
Copy link
Author

cidkidnix commented Jun 29, 2020

I'll take a look in that case when I get a chance, everything should work as I'm running bcachefs as my rootfs right now but I'll take a look

@cidkidnix
Copy link
Author

cidkidnix commented Jun 29, 2020

I think the test may be messed up, as this BCH_IOCTL_DEV_USAGE ioctl error: Inappropriate ioctl for device always happens for some reason, it's probably a bcachefs issue not a implement issue on my end

@eadwu
Copy link
Member

eadwu commented Jun 30, 2020

I currently don't use bcachefs much anymore (or at least not as my main filesystem).

If you're upgrading bcachefs, you should also fix the version at bcachefs-tools. On the same note, the latest commit of the source tree used in bcachefs-tools should be what bcachefs points towards for basic sanity. Note that it doesn't ensure that they work but that the tool/kernel is compatible.

@cidkidnix
Copy link
Author

cidkidnix commented Jun 30, 2020

I've updated bcachefs-tools to the latest working commit, the latest commit works in theory but a pytest that fails, makes it fail to build even though it's non fatal, I also updated the kernel commit for some improvements that just got pushed. The IOCTL error seems to be a literal issue with bcachefs

@cidkidnix
Copy link
Author

cidkidnix commented Jun 30, 2020

I'm not sure why ofborg is failing in this case, it's building fine on my system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.