Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
haskellPackages.gi-webkit2: Fix build #91755
Motivation for this change
Fixing some package builds.
I strongly believe, that all overrides in
Let me see if I understand what is going on here:
This means that in order to build
The code in this PR is as follows:
This means that
I don't have a strong opinion for or against this, but I do have a couple concerns:
Yes, that is exactly right.
That is right. But my primary concern is to not have this jailbreak linger here forever.
That is a valid concern I hadn‘t thought about.
So my summary is. I agree that it might be a problem that you cannot override the assert, but I can‘t think of a situation where the assert would fail without that being intended.
I am not a big fan of the stringly typed "older" in there, but yeah, that might be a good idea. In general I think it would be great to annotate overrides in
(Although I do think that we should provide a separate
Ah, yeah, I completely agree.
Ping @peti to see how he feels about this.