Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphite-web: fix patch #91756

Merged
merged 3 commits into from Jun 30, 2020
Merged

graphite-web: fix patch #91756

merged 3 commits into from Jun 30, 2020

Conversation

@JJJollyjim
Copy link
Contributor

JJJollyjim commented Jun 29, 2020

Motivation for this change

The update to 1.1.7 reformatted things, so the build broke.

The test has been disabled for a long time: the reason in the comment no longer applies now that graphite things use python3, so it now passes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JJJollyjim JJJollyjim requested review from FRidh and jonringer as code owners Jun 29, 2020
@JJJollyjim
Copy link
Contributor Author

JJJollyjim commented Jun 29, 2020

@ofborg test graphite

Until now, it was failing to start in the test, as it was searching for an
influxdb database
@lsix
lsix approved these changes Jun 29, 2020
Copy link
Member

lsix left a comment

Built and tested.

All fine for me.

@lsix lsix merged commit a3db82f into NixOS:master Jun 30, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f31678"; rev="3f31678607f51973cbeb3d72437b950c52510685"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.