Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_shell: remove #91764

Merged
merged 1 commit into from Jun 29, 2020
Merged

aws_shell: remove #91764

merged 1 commit into from Jun 29, 2020

Conversation

@cransom
Copy link
Contributor

cransom commented Jun 29, 2020

It appears to have been broken for the last few releases and has had no
upstream updates for the last 2 years. I originally committed this but
didn't add myself to maintainers.

Motivation for this change

Clean out broken packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92
Copy link
Contributor

Mic92 commented Jun 29, 2020

You removed awscli instead of aws_shell

It appears to have been broken for the last few releases and has had no
upstream updates for the last 2 years. I originally committed this but
didn't add myself to maintainers.
@cransom cransom force-pushed the cransom:cransom/remove-aws_shell branch from 639ab50 to c7705e6 Jun 29, 2020
@cransom
Copy link
Contributor Author

cransom commented Jun 29, 2020

Wooo oops. I'm sure that was subconcious wishful thinking.

@Mic92 Mic92 merged commit dea62a1 into NixOS:master Jun 29, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7705e6"; rev="c7705e6339844d68fa4fdde1b4e875a1bdac1ffb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.