Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

littlegptracker: init at unstable-2019-04-14 #91766

Open
wants to merge 1 commit into
base: master
from

Conversation

@fgaz
Copy link
Member

fgaz commented Jun 29, 2020

Motivation for this change

#81815

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/marvin needs_review

@fgaz fgaz marked this pull request as draft Jun 29, 2020
@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020

Oops, got the prs mixed while waiting for the github downtime to end, this should be a draft for now. Fortunately marvin didn't get triggered.

@fgaz fgaz mentioned this pull request Jun 29, 2020
10 of 46 tasks complete
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch from 4d2c453 to 3c9ba17 Aug 1, 2020
@fgaz fgaz marked this pull request as ready for review Aug 1, 2020
@fgaz fgaz marked this pull request as draft Aug 1, 2020
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch 5 times, most recently from 81c16dc to e42de70 Aug 1, 2020
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch from e42de70 to 0b4401d Aug 1, 2020
@fgaz fgaz marked this pull request as ready for review Aug 1, 2020
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch from 0b4401d to 8bd451b Aug 1, 2020
@fgaz
Copy link
Member Author

fgaz commented Aug 1, 2020

Ok, it's ready now

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 1, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Aug 1, 2020
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch from 8bd451b to f3078e2 Aug 1, 2020
@fgaz fgaz force-pushed the fgaz:littlegptracker/init branch from f3078e2 to 8cfb78b Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.