Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shattered-pixel-dungeon: 0.8.0b -> 0.8.1 #91767

Merged
merged 1 commit into from Jun 29, 2020

Conversation

@fgaz
Copy link
Member

fgaz commented Jun 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020

/marvin opt-in
/marvin needs_review

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 29, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020

oops
/status needs_review

Copy link
Member

danieldk left a comment

LGTM

Result of nixpkgs-review pr 91767 1

1 package built:
- shattered-pixel-dungeon

Works as expected.

@danieldk danieldk merged commit 7801614 into NixOS:master Jun 29, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75d9ea9"; rev="75d9ea9671b9277748cc53b9f9551f810c6a3a2c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
shattered-pixel-dungeon, shattered-pixel-dungeon.passthru.tests on aarch64-linux Success
Details
shattered-pixel-dungeon, shattered-pixel-dungeon.passthru.tests on x86_64-darwin Success
Details
shattered-pixel-dungeon, shattered-pixel-dungeon.passthru.tests on x86_64-linux Success
Details
@fgaz fgaz deleted the fgaz:shattered-pixel-dungeon/0.8.1 branch Jun 30, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.