Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antimicro 2.3 -> antimicroX 3.0 #91776

Open
wants to merge 1 commit into
base: master
from

Conversation

@KoviRobi
Copy link
Contributor

KoviRobi commented Jun 29, 2020

Antimicro is broken an no longer maintained (and doesn't compile).
AntimicroX is a fork that does compile, so this removes antimicro and
adds antimicroX.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Antimicro is broken an no longer maintained (and doesn't compile).
AntimicroX is a fork that does compile, so this removes antimicro and
adds antimicroX.
@KoviRobi KoviRobi requested a review from jb55 Jun 29, 2020
@KoviRobi
Copy link
Contributor Author

KoviRobi commented Jun 29, 2020

Sorry, I was meant to add a reviewer, not an assignee, and now can't remove you as an assignee.

@KoviRobi
Copy link
Contributor Author

KoviRobi commented Jul 10, 2020

I have been using this software, because of working from home but having to use a work laptop, but my music is on my desktop computer. So I have hooked up a spare PS3 controller, and used this to map buttons to volume up/down, and play/pause. Seems to work fine.

@jb55
jb55 approved these changes Jul 11, 2020
Copy link
Contributor

jb55 left a comment

thanks! lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.