Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: 1.44.7 -> 1.45.3 #91777

Merged
merged 1 commit into from Jul 26, 2020
Merged

pango: 1.44.7 -> 1.45.3 #91777

merged 1 commit into from Jul 26, 2020

Conversation

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 29, 2020

Motivation for this change

This update is needed to cleanly apply a patch, which fixes the issue that required to split the outputs of type1 bitmap fonts.
See #75160 for why this is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (for harfbuzz, mostly negligible)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

For now I've built a VM with xfce and tested a couple GTK applications.

Copy link
Contributor

jtojnar left a comment

This is possibly unstable version but if the changes are conservative we can probably merge it.

Away from computer today and tomorrow so cannot review the changes at the moment.

pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/pango/default.nix Outdated Show resolved Hide resolved
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:pango branch from 94493fa to 3ad97d5 Jun 29, 2020
@FRidh FRidh added this to WIP in Staging via automation Jul 2, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jul 2, 2020
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:pango branch from 3ad97d5 to 2a87459 Jul 16, 2020
@rnhmjoj rnhmjoj changed the base branch from master to staging-18.03 Jul 16, 2020
@rnhmjoj rnhmjoj requested review from edwtjo, Ericson2314, FRidh, nbp and rycee as code owners Jul 16, 2020
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:pango branch from 2a87459 to e3e09e1 Jul 16, 2020
@rnhmjoj rnhmjoj changed the base branch from staging-18.03 to staging Jul 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 20, 2020

I think it is fine. The changelogs did not mention any API changes, if I did not miss something, so hopefully nothing should break.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 20, 2020

Would be nice if the darwin build succeeded, though.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 22, 2020

@GrahamcOfBorg build pango harfbuzz

@jtojnar jtojnar mentioned this pull request Jul 25, 2020
6 of 10 tasks complete
@cdepillabout
Copy link
Member

cdepillabout commented Jul 25, 2020

@rnhmjoj Would you be able to pull in the "--enable-introspection=yes" line from #93799?

Or, it looks like the darwin build has succeeded, so maybe this could just be merged in? And then I'll rebase #93799 on top of this PR.

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:pango branch from dbcff1f to d567321 Jul 26, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 26, 2020

Finally the darwin test passed. Let's merge it.

@rnhmjoj rnhmjoj merged commit 500f48b into NixOS:staging Jul 26, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d567321"; rev="d5673218dfd87bc1b71da65549bfc6b02788b388"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pango, pango.passthru.tests on aarch64-linux Success
Details
pango, pango.passthru.tests on x86_64-darwin Success
Details
pango, pango.passthru.tests on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.