Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.{confuse,mediafile}: init #91789

Open
wants to merge 2 commits into
base: master
from

Conversation

@lovesegfault
Copy link
Contributor

lovesegfault commented Jun 29, 2020

Motivation for this change

These will soon be needed for a new release of beets

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lovesegfault lovesegfault force-pushed the lovesegfault:confuse-mediafile branch from 15425ec to 77ff9f2 Jun 29, 2020
@lovesegfault
Copy link
Contributor Author

lovesegfault commented Jun 29, 2020

@jonringer Fastest review in the west! I think I got everything :)

@lovesegfault lovesegfault requested a review from jonringer Jun 29, 2020
@lovesegfault lovesegfault force-pushed the lovesegfault:confuse-mediafile branch from 77ff9f2 to c274567 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.