Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytorch: 1.5.0 -> 1.5.1 #91808

Merged
merged 2 commits into from Jul 4, 2020
Merged

Conversation

@danieldk
Copy link
Member

danieldk commented Jun 30, 2020

Motivation for this change
  • Update PyTorch to 1.5.1.

  • Fix AArch64 build error.

  • Tested CUDA build: ✔️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk
Copy link
Member Author

danieldk commented Jun 30, 2020

@GrahamcOfBorg build python3Packages.pytorch

@danieldk danieldk marked this pull request as ready for review Jun 30, 2020
@danieldk danieldk requested review from FRidh and jonringer as code owners Jun 30, 2020
@danieldk danieldk force-pushed the danieldk:pytorch-1.5.1 branch from 77dfed2 to 62b3e76 Jun 30, 2020
aarch64-linux builds fail because of the use of opcodes in QNNPACK
that the GNU assembpler does not support. This change cherry-picks an
upstream patch that fixes this. See:

pytorch/pytorch#33124
pytorch/pytorch#40584
@danieldk danieldk force-pushed the danieldk:pytorch-1.5.1 branch from 62b3e76 to 5c80cde Jun 30, 2020
@danieldk
Copy link
Member Author

danieldk commented Jun 30, 2020

@ofborg build python37Packages.pytorch python38Packages.pytorch

@nixos-discourse
Copy link

nixos-discourse commented Jul 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/211

@jonringer jonringer mentioned this pull request Jul 3, 2020
4 of 10 tasks complete
@danieldk
Copy link
Member Author

danieldk commented Jul 4, 2020

cc: @drewrisinger @mweinelt since you have reviewed previous pytorch bumps and/or related packages.

Edit: oops, sorry saw that jonringer was already looking at this. Well, the more eyeballs the better I guess ;).

@FRidh FRidh merged commit a9ed5b7 into NixOS:master Jul 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c80cde"; rev="5c80cdeb1a0f6c8e32e7990025ec21d00cbdbbe2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.pytorch, python38Packages.pytorch on aarch64-linux Success
Details
python37Packages.pytorch, python38Packages.pytorch on x86_64-linux Success
Details
@jonringer
Copy link
Contributor

jonringer commented Jul 4, 2020

Needed to run the review on my server, as my desktop isn't powerful enough. but fridh beat me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.