Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: cleaning up obsolete overrides (14/x) #91879

Merged
merged 1 commit into from Jul 2, 2020

Conversation

@svmhdvn
Copy link
Contributor

svmhdvn commented Jun 30, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

lenz-template: -doJailbreak
resolv: -dontCheck
cassava: -doJailbreak
language-ecmascript: -doJailbreak
xmlhtml: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@svmhdvn svmhdvn requested a review from cdepillabout as a code owner Jun 30, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jun 30, 2020

@GrahamcOfBorg build haskellPackages.lenz-template
@GrahamcOfBorg build haskellPackages.resolv
@GrahamcOfBorg build haskellPackages.cassava
@GrahamcOfBorg build haskellPackages.language-ecmascript
@GrahamcOfBorg build haskellPackages.xmlhtml

@cdepillabout
Copy link
Member

cdepillabout commented Jul 1, 2020

Ah, sorry, it looks like there is a conflict here.

Could you fix this up? Once you do, this can be merged in.

lenz-template: -doJailbreak
resolv: -dontCheck
cassava: -doJailbreak
language-ecmascript: -doJailbreak
xmlhtml: -doJailbreak
@svmhdvn svmhdvn force-pushed the svmhdvn:overrides-14 branch from 0bc85d8 to 1e807cd Jul 1, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 1, 2020

This should fix it, do you need to rerun the builds?

@cdepillabout
Copy link
Member

cdepillabout commented Jul 2, 2020

@GrahamcOfBorg build haskellPackages.lenz-template
@GrahamcOfBorg build haskellPackages.resolv
@GrahamcOfBorg build haskellPackages.cassava
@GrahamcOfBorg build haskellPackages.language-ecmascript
@GrahamcOfBorg build haskellPackages.xmlhtml

@cdepillabout
Copy link
Member

cdepillabout commented Jul 2, 2020

LGTM, thanks

@cdepillabout cdepillabout merged commit eb63d9d into NixOS:haskell-updates Jul 2, 2020
21 of 29 checks passed
21 of 29 checks passed
haskellPackages.cassava on aarch64-linux
Details
haskellPackages.cassava on x86_64-darwin
Details
haskellPackages.language-ecmascript on aarch64-linux
Details
haskellPackages.language-ecmascript on x86_64-darwin
Details
haskellPackages.lenz-template on aarch64-linux
Details
haskellPackages.resolv on aarch64-linux
Details
haskellPackages.xmlhtml on aarch64-linux
Details
haskellPackages.xmlhtml on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e807cd"; rev="1e807cd25b1fa09e146510cc9458872f17427922"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskellPackages.cassava on x86_64-linux Success
Details
haskellPackages.language-ecmascript on x86_64-linux Success
Details
haskellPackages.lenz-template on x86_64-darwin Success
Details
haskellPackages.lenz-template on x86_64-linux Success
Details
haskellPackages.resolv on x86_64-darwin Success
Details
haskellPackages.resolv on x86_64-linux Success
Details
haskellPackages.xmlhtml on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.