Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: cleaning up obsolete overrides (15/x) #91881

Merged
merged 1 commit into from Jul 1, 2020

Conversation

@svmhdvn
Copy link
Contributor

svmhdvn commented Jun 30, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

web-routes-th: -doJailbreak
load-env: -dontCheck
servant-swagger: -dontCheck
vector-algorithms: -dontCheck
graphviz: -dontCheck

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
web-routes-th: -doJailbreak
load-env: -dontCheck
servant-swagger: -dontCheck
vector-algorithms: -dontCheck
graphviz: -dontCheck
@svmhdvn svmhdvn requested a review from cdepillabout as a code owner Jun 30, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jun 30, 2020

@GrahamcOfBorg build haskellPackages.web-routes-th
@GrahamcOfBorg build haskellPackages.load-env
@GrahamcOfBorg build haskellPackages.servant-swagger
@GrahamcOfBorg build haskellPackages.vector-algorithms
@GrahamcOfBorg build haskellPackages.graphviz

@cdepillabout
Copy link
Member

cdepillabout commented Jul 1, 2020

Looks good, and thanks for removing unnecessary comments as well!

@cdepillabout cdepillabout merged commit 80fce2e into NixOS:haskell-updates Jul 1, 2020
24 checks passed
24 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5cd8370"; rev="5cd8370d27b6a931ed95dc525fcb22ecc8cc9a7b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskellPackages.graphviz on aarch64-linux Success
Details
haskellPackages.graphviz on x86_64-linux Success
Details
haskellPackages.load-env on aarch64-linux Success
Details
haskellPackages.load-env on x86_64-linux Success
Details
haskellPackages.servant-swagger on aarch64-linux Success
Details
haskellPackages.servant-swagger on x86_64-linux Success
Details
haskellPackages.vector-algorithms on aarch64-linux Success
Details
haskellPackages.vector-algorithms on x86_64-linux Success
Details
haskellPackages.web-routes-th on aarch64-linux Success
Details
haskellPackages.web-routes-th on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.