Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: cleaning up obsolete overrides (17/x) #91885

Merged
merged 1 commit into from Jul 1, 2020

Conversation

@svmhdvn
Copy link
Contributor

svmhdvn commented Jun 30, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

attoparsec: -dontCheck
nix-derivation: -doJailbreak
cryptohash-sha256: -dontCheck
text-short: -doJailbreak
genvalidity-property: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
attoparsec: -dontCheck
nix-derivation: -doJailbreak
cryptohash-sha256: -dontCheck
text-short: -doJailbreak
genvalidity-property: -doJailbreak
@svmhdvn svmhdvn requested a review from cdepillabout as a code owner Jun 30, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jun 30, 2020

@GrahamcOfBorg build haskellPackages.attoparsec
@GrahamcOfBorg build haskellPackages.nix-derivation
@GrahamcOfBorg build haskellPackages.cryptohash-sha256
@GrahamcOfBorg build haskellPackages.text-short
@GrahamcOfBorg build haskellPackages.genvalidity-property

@cdepillabout
Copy link
Member

cdepillabout commented Jul 1, 2020

Thanks (17/x)!

@cdepillabout cdepillabout merged commit 91f867f into NixOS:haskell-updates Jul 1, 2020
24 checks passed
24 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f979a88"; rev="f979a8861cc7b98cd9e1703c23b502c2e7027a93"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskellPackages.attoparsec on aarch64-linux Success
Details
haskellPackages.attoparsec on x86_64-linux Success
Details
haskellPackages.cryptohash-sha256 on aarch64-linux Success
Details
haskellPackages.cryptohash-sha256 on x86_64-linux Success
Details
haskellPackages.genvalidity-property on aarch64-linux Success
Details
haskellPackages.genvalidity-property on x86_64-linux Success
Details
haskellPackages.nix-derivation on aarch64-linux Success
Details
haskellPackages.nix-derivation on x86_64-linux Success
Details
haskellPackages.text-short on aarch64-linux Success
Details
haskellPackages.text-short on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.