Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp, vim-osc52, vim-poweryank #91894

Merged
merged 9 commits into from Aug 15, 2020

Conversation

@onsails
Copy link
Contributor

onsails commented Jun 30, 2020

Please note that for vim-clap, there is additional stage of building maple rust binary which sources are bundled into vim-clap plugin.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@onsails onsails requested a review from jonringer as a code owner Jun 30, 2020
@ofborg ofborg bot requested a review from jorsn Jun 30, 2020
@onsails onsails changed the title Add vim-clap Add vim-clap and coc-clap Jun 30, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch 3 times, most recently from 03bc386 to be53614 Jul 4, 2020
@onsails onsails changed the title Add vim-clap and coc-clap Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp Jul 10, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch 2 times, most recently from bf667f9 to 62552c2 Jul 16, 2020
@ofborg ofborg bot requested a review from jagajaga Jul 17, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch 5 times, most recently from 7107d09 to 5963a5d Jul 17, 2020
@onsails onsails changed the title Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp, vim-osc52 Jul 19, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch from 5963a5d to 31e8542 Jul 20, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch 2 times, most recently from 9369e2c to ccc13d0 Jul 31, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch 2 times, most recently from ff408b3 to ec5aa69 Aug 14, 2020
@onsails onsails changed the title Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp, vim-osc52 Add vim-clap, coc-clap, coc-explorer, coc-markdownlint, coc-vimlsp, vim-osc52, vim-poweryank Aug 14, 2020
@jonringer
Copy link
Contributor

jonringer commented Aug 15, 2020

Copy link
Contributor

jonringer left a comment

do you mind following https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs

there should be an update commit.

at least, it should resolve the conflict

pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
@onsails onsails force-pushed the onsails:vim-plugins branch from 88814e0 to 81ade00 Aug 15, 2020
@onsails onsails force-pushed the onsails:vim-plugins branch from 81ade00 to b848e36 Aug 15, 2020
@onsails
Copy link
Contributor Author

onsails commented Aug 15, 2020

Thanks for the review!
I've made a symlink and executed update script.

Copy link
Contributor

jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/91894
24 packages built:
vimPlugins.nerdtree vimPlugins.awesome-vim-colorschemes vimPlugins.calendar vimPlugins.coc-clap vimPlugins.coc-explorer vimPlugins.coc-fzf vimPlugins.coc-markdownlint vimPlugins.coc-vimlsp vimPlugins.vim-css-color vimPlugins.dart-vim-plugin vimPlugins.defx-nvim vimPlugins.denite-git vimPlugins.lightline-vim vimPlugins.nvim-treesitter vimPlugins.polyglot vimPlugins.rust-vim vimPlugins.thumbnail vimPlugins.vim-clap vimPlugins.vim-devicons vimPlugins.vim-isort vimPlugins.vim-osc52 vimPlugins.vim-poweryank vimPlugins.vim-visual-multi vimPlugins.vim-vsnip
@jonringer jonringer merged commit 7ae8aec into NixOS:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.