Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jupyter service #91895

Merged
merged 2 commits into from Jul 11, 2020
Merged

Improve jupyter service #91895

merged 2 commits into from Jul 11, 2020

Conversation

@kristoff3r
Copy link
Contributor

@kristoff3r kristoff3r commented Jun 30, 2020

Motivation for this change

I want to use the jupyter service with the jupyterWith package and a Rust kernel, so I added the necessary options to make that work. I also fixed a bug in the evcxr package. I have tested both of these changes on my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kristoff3r kristoff3r changed the title services.jupyter: add options Improve jupyter service Jun 30, 2020
@ofborg ofborg bot requested review from protoben and Ma27 Jun 30, 2020
@kristoff3r kristoff3r force-pushed the kristoff3r:jupyter-service branch from 7900632 to 910f8f2 Jul 1, 2020
@kristoff3r kristoff3r requested a review from FRidh Jul 1, 2020
@kristoff3r
Copy link
Contributor Author

@kristoff3r kristoff3r commented Jul 1, 2020

I changed useJupyterLabs to a command option. I can't retest it myself right now because I am at work, but the change is hopefully small enough for it to still work.

Thanks for the quick review!

@FRidh FRidh requested a review from aborsu Jul 1, 2020
kristoff3r added 2 commits Jun 30, 2020
evcxr_jupyter needs the same wrapper as the main binary to work.
@kristoff3r kristoff3r force-pushed the kristoff3r:jupyter-service branch from 910f8f2 to a8b68fc Jul 7, 2020
@kristoff3r
Copy link
Contributor Author

@kristoff3r kristoff3r commented Jul 9, 2020

I fixed accidentally using types.string instead of types.str, and me plus another person have been using this without problems for a week now. The default behavior is also exactly the same as before, so I think this can be safely merged.

@Ma27
Ma27 approved these changes Jul 11, 2020
@Ma27 Ma27 merged commit 3d9c143 into NixOS:master Jul 11, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
evcxr, evcxr.passthru.tests on aarch64-linux Success
Details
evcxr, evcxr.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8b68fc"; rev="a8b68fc49f4edeacad1919bd14443dead792fccf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.