Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeal: 0.6.1 -> 0.6.999 #91913

Merged
merged 1 commit into from Jul 2, 2020
Merged

zeal: 0.6.1 -> 0.6.999 #91913

merged 1 commit into from Jul 2, 2020

Conversation

@peterhoeg
Copy link
Member

peterhoeg commented Jul 1, 2020

Motivation for this change

Upstream is getting very close to releasing 0.7.0 but 0.6.1 depends on
qtwebkit which is deprecated and no longer built by hydra, so better
jump to the newer version that works with qtwebengine.

This works just as well as 0.6.1 and will be updated when 0.7.0 proper
is released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from svenkeidel Jul 1, 2020
@peterhoeg peterhoeg changed the title zeal: 0.6.1 -> 0.7.0pre zeal: 0.6.1 -> 0.6.999 Jul 1, 2020
@peterhoeg peterhoeg force-pushed the peterhoeg:u/zeal branch from d226a26 to b25c98e Jul 1, 2020
@peterhoeg
Copy link
Member Author

peterhoeg commented Jul 1, 2020

@worldofpeace and @jonringer - any comments as master reviewers?

@teto
Copy link
Contributor

teto commented Jul 1, 2020

oh sweet, I just noticed I was buiilding qtwebkit because of zeal this morning.

@peterhoeg
Copy link
Member Author

peterhoeg commented Jul 2, 2020

I just noticed I was buiilding qtwebkit because of zeal this morning.

That's how I noticed as well...

@peterhoeg peterhoeg merged commit 2676464 into NixOS:master Jul 2, 2020
15 of 16 checks passed
15 of 16 checks passed
zeal, zeal.passthru.tests on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b25c98e"; rev="b25c98ed29f1dd022d95da1eaf96d139b21a0ed8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zeal, zeal.passthru.tests on x86_64-linux Success
Details
@peterhoeg peterhoeg deleted the peterhoeg:u/zeal branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.